On Wed, Feb 28, 2018 at 01:09:29PM +0200, Jyri Sarha wrote: > Setting the connector and drm to NULL when the drm panel device is > going away hardly serves any purpose. Usually the the whole memory > stucture is freed right after the remove call. > > Signed-off-by: Jyri Sarha <jsa...@ti.com> > --- > drivers/gpu/drm/panel/panel-innolux-p079zca.c | 1 - > drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 1 - > drivers/gpu/drm/panel/panel-lvds.c | 1 - > drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 1 - > drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 1 - > drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 1 - > drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 1 - > drivers/gpu/drm/panel/panel-simple.c | 1 - > drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 1 - > 9 files changed, 9 deletions(-)
I don't understand the purpose of this patch. I'll grant you that the current implementation of drm_panel_detach() is not very useful, but then you add code to drm_panel_detach() in the next patch and mention in the commit message that panel drivers should be calling the drm_panel_detach() function to remove the link. This is confusing. Can you clarify? Thierry
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
