On 28 March 2018 at 18:04, Christian König <christian.koe...@amd.com> wrote: > Am 28.03.2018 um 17:53 schrieb Arnd Bergmann: >> >> Building amdkfd without MMU notifiers is broken: >> >> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28: >> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' >> has incomplete type >> >> This adds the missing 'select MMU_NOTIFIER' line to make it build >> cleanly all the time. >> >> Signed-off-by: Arnd Bergmann <a...@arndb.de> > > > Acked-by: Christian König <christian.koe...@amd.com>, but I would wait on > what Felix says to that.
Tested-by: Anders Roxell <anders.rox...@linaro.org> Randy sent the same patch [1] and its still required. Cheers, Anders [1] https://patchwork.kernel.org/patch/10340885/ > > >> --- >> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig >> b/drivers/gpu/drm/amd/amdkfd/Kconfig >> index ed2f06c9f346..5a26acb90e19 100644 >> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig >> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig >> @@ -4,6 +4,7 @@ >> config HSA_AMD >> tristate "HSA kernel driver for AMD GPU devices" >> + select MMU_NOTIFIER >> depends on DRM_AMDGPU && X86_64 >> imply AMD_IOMMU_V2 >> help > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
