Hi Stefan, Thank you for the patch! Yet something to improve:
[auto build test ERROR on v4.17-rc1] [also build test ERROR on next-20180420] [cannot apply to anholt/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stefan-Schake/drm-vc4-Add-support-for-plane-alpha/20180423-002110 config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sh All errors (new ones prefixed by >>): drivers/gpu/drm/vc4/vc4_plane.c: In function 'vc4_plane_reset': >> drivers/gpu/drm/vc4/vc4_plane.c:204:14: error: 'struct drm_plane_state' has >> no member named 'alpha' plane->state->alpha = DRM_BLEND_ALPHA_OPAQUE; ^~ >> drivers/gpu/drm/vc4/vc4_plane.c:204:24: error: 'DRM_BLEND_ALPHA_OPAQUE' >> undeclared (first use in this function) plane->state->alpha = DRM_BLEND_ALPHA_OPAQUE; ^~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/vc4/vc4_plane.c:204:24: note: each undeclared identifier is reported only once for each function it appears in In file included from drivers/gpu/drm/vc4/vc4_plane.c:28:0: drivers/gpu/drm/vc4/vc4_plane.c: In function 'vc4_plane_mode_set': drivers/gpu/drm/vc4/vc4_plane.c:557:23: error: 'struct drm_plane_state' has no member named 'alpha' VC4_SET_FIELD(state->alpha >> 8, SCALER_POS0_FIXED_ALPHA) | ^ drivers/gpu/drm/vc4/vc4_regs.h:18:24: note: in definition of macro 'VC4_SET_FIELD' uint32_t fieldval = (value) << field##_SHIFT; \ ^~~~~ drivers/gpu/drm/vc4/vc4_plane.c:574:25: error: 'struct drm_plane_state' has no member named 'alpha' mix_plane_alpha = state->alpha != DRM_BLEND_ALPHA_OPAQUE && ^~ drivers/gpu/drm/vc4/vc4_plane.c:574:36: error: 'DRM_BLEND_ALPHA_OPAQUE' undeclared (first use in this function) mix_plane_alpha = state->alpha != DRM_BLEND_ALPHA_OPAQUE && ^~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/vc4/vc4_plane.c: In function 'vc4_plane_init': >> drivers/gpu/drm/vc4/vc4_plane.c:952:2: error: implicit declaration of >> function 'drm_plane_create_alpha_property'; did you mean >> 'drm_plane_create_zpos_property'? [-Werror=implicit-function-declaration] drm_plane_create_alpha_property(plane); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drm_plane_create_zpos_property cc1: some warnings being treated as errors vim +204 drivers/gpu/drm/vc4/vc4_plane.c 191 192 /* Called during init to allocate the plane's atomic state. */ 193 static void vc4_plane_reset(struct drm_plane *plane) 194 { 195 struct vc4_plane_state *vc4_state; 196 197 WARN_ON(plane->state); 198 199 vc4_state = kzalloc(sizeof(*vc4_state), GFP_KERNEL); 200 if (!vc4_state) 201 return; 202 203 plane->state = &vc4_state->base; > 204 plane->state->alpha = DRM_BLEND_ALPHA_OPAQUE; 205 vc4_state->base.plane = plane; 206 } 207 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel