On Tue, Apr 24, 2018 at 10:55:05AM -0700, matthew.s.atw...@intel.com wrote:
> From: Matt Atwood <matthew.s.atw...@intel.com>

please add the message:

Based on kernel commit '672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'

> 
> v2: name change M -> ULX, add enumeration in KBL ULX
> 
> Signed-off-by: Matt Atwood <matthew.s.atw...@intel.com>
> ---
>  intel/intel_chipset.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
> index 01d250e..f479bc4 100644
> --- a/intel/intel_chipset.h
> +++ b/intel/intel_chipset.h
> @@ -200,7 +200,8 @@
>  #define PCI_CHIP_KABYLAKE_ULT_GT2F   0x5921
>  #define PCI_CHIP_KABYLAKE_ULX_GT1_5  0x5915
>  #define PCI_CHIP_KABYLAKE_ULX_GT1    0x590E
> -#define PCI_CHIP_KABYLAKE_ULX_GT2    0x591E
> +#define PCI_CHIP_KABYLAKE_ULX_GT2_0  0x591E
> +#define PCI_CHIP_KABYLAKE_ULX_GT2_1  0x591C
>  #define PCI_CHIP_KABYLAKE_DT_GT2     0x5912
>  #define PCI_CHIP_KABYLAKE_M_GT2              0x5917
>  #define PCI_CHIP_KABYLAKE_DT_GT1     0x5902

The define itself isn't enough... you still missed the enable part:

#define IS_KBL_GT2(devid)       ((devid) == PCI_CHIP_KABYLAKE_ULX_GT2_...

sorry for not being clear about the "enable" part on previous review.

> -- 
> 2.7.4
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to