Hi, On Wed, Jun 06, 2018 at 12:36:31PM +0300, Laurent Pinchart wrote: > The .get_mirror() and .set_mirror() omap_dss_driver operations are > implemented by the panel-tpo-td043mtea1 driver but are never used. > Remove them. > > Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> .../drm/omapdrm/displays/panel-tpo-td043mtea1.c | 25
> ++--------------------
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 ---
> 2 files changed, 2 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
> b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
> index cb6f19f8a0da..34531169c166 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
> @@ -62,7 +62,6 @@ struct panel_drv_data {
> int nreset_gpio;
> u16 gamma[12];
> u32 mode;
> - u32 hmirror:1;
> u32 vmirror:1;
> u32 powered_on:1;
> u32 spi_suspended:1;
> @@ -151,22 +150,6 @@ static int tpo_td043_write_mirror(struct spi_device
> *spi, bool h, bool v)
> return tpo_td043_write(spi, 4, reg4);
> }
>
> -static int tpo_td043_set_hmirror(struct omap_dss_device *dssdev, bool enable)
> -{
> - struct panel_drv_data *ddata = dev_get_drvdata(dssdev->dev);
> -
> - ddata->hmirror = enable;
> - return tpo_td043_write_mirror(ddata->spi, ddata->hmirror,
> - ddata->vmirror);
> -}
> -
> -static bool tpo_td043_get_hmirror(struct omap_dss_device *dssdev)
> -{
> - struct panel_drv_data *ddata = dev_get_drvdata(dssdev->dev);
> -
> - return ddata->hmirror;
> -}
> -
> static ssize_t tpo_td043_vmirror_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> @@ -188,7 +171,7 @@ static ssize_t tpo_td043_vmirror_store(struct device *dev,
>
> val = !!val;
>
> - ret = tpo_td043_write_mirror(ddata->spi, ddata->hmirror, val);
> + ret = tpo_td043_write_mirror(ddata->spi, false, val);
> if (ret < 0)
> return ret;
>
> @@ -307,8 +290,7 @@ static int tpo_td043_power_on(struct panel_drv_data
> *ddata)
> tpo_td043_write(ddata->spi, 3, TPO_R03_VAL_NORMAL);
> tpo_td043_write(ddata->spi, 0x20, 0xf0);
> tpo_td043_write(ddata->spi, 0x21, 0xf0);
> - tpo_td043_write_mirror(ddata->spi, ddata->hmirror,
> - ddata->vmirror);
> + tpo_td043_write_mirror(ddata->spi, false, ddata->vmirror);
> tpo_td043_write_gamma(ddata->spi, ddata->gamma);
>
> ddata->powered_on = 1;
> @@ -435,9 +417,6 @@ static const struct omap_dss_driver tpo_td043_ops = {
> .set_timings = tpo_td043_set_timings,
> .get_timings = tpo_td043_get_timings,
> .check_timings = tpo_td043_check_timings,
> -
> - .set_mirror = tpo_td043_set_hmirror,
> - .get_mirror = tpo_td043_get_hmirror,
> };
>
> static int tpo_td043_probe_of(struct spi_device *spi)
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index 77ba8ace6795..3bfb62b28a77 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -444,9 +444,6 @@ struct omap_dss_driver {
> int (*enable_te)(struct omap_dss_device *dssdev, bool enable);
> int (*get_te)(struct omap_dss_device *dssdev);
>
> - bool (*get_mirror)(struct omap_dss_device *dssdev);
> - int (*set_mirror)(struct omap_dss_device *dssdev, bool enable);
> -
> int (*memory_read)(struct omap_dss_device *dssdev,
> void *buf, size_t size,
> u16 x, u16 y, u16 w, u16 h);
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
