On Thu, Jul 12, 2018 at 02:58:00PM +0300, Oleksandr Andrushchenko wrote: > On 06/18/2018 03:32 PM, Oleksandr Andrushchenko wrote: > > On 06/18/2018 03:29 PM, Dan Carpenter wrote: > > > On Mon, Jun 18, 2018 at 09:07:09AM +0300, Oleksandr Andrushchenko wrote: > > > > drivers/gpu/drm/drm_gem_cma_helper.c | 2 +- > > > > drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +- > > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c > > > > b/drivers/gpu/drm/drm_gem_cma_helper.c > > > > index 80a5115c3846..ce868ce288fb 100644 > > > > --- a/drivers/gpu/drm/drm_gem_cma_helper.c > > > > +++ b/drivers/gpu/drm/drm_gem_cma_helper.c > > > > @@ -436,7 +436,7 @@ struct sg_table > > > > *drm_gem_cma_prime_get_sg_table(struct drm_gem_object *obj) > > > > sgt = kzalloc(sizeof(*sgt), GFP_KERNEL); > > > > if (!sgt) > > > > - return NULL; > > > > + return ERR_PTR(-ENOMEM); > > > > ret = dma_get_sgtable(obj->dev->dev, sgt, cma_obj->vaddr, > > > > cma_obj->paddr, obj->size); > > > > > > If dma_get_sgtable() fails then we return NULL. > > > > > > Fix that and it should be good. > > You mean I can put your r-b with that fixed? > ping
Yeah. Send the v2 patch and I'll review it. regards, dan carpenter _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
