It occurred to me that we never actually check this! So let's start
doing that.

Signed-off-by: Lyude Paul <ly...@redhat.com>
Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c 
b/drivers/gpu/drm/drm_dp_mst_topology.c
index adb4298570cc..cafb769a4ec3 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -3225,7 +3225,7 @@ static int drm_dp_mst_atomic_check(struct drm_private_obj 
*obj,
                to_dp_mst_topology_state(state);
        struct drm_dp_mst_topology_mgr *mgr = mst_state->mgr;
        struct drm_dp_vcpi_allocation *pos;
-       int avail_slots = 63;
+       int avail_slots = 63, payload_count = 0;
 
        list_for_each_entry(pos, &mst_state->vcpis, next) {
                DRM_DEBUG_ATOMIC("[MST PORT:%p] requires %d vcpi slots\n",
@@ -3238,6 +3238,12 @@ static int drm_dp_mst_atomic_check(struct 
drm_private_obj *obj,
                                         avail_slots + pos->vcpi);
                        return -ENOSPC;
                }
+
+               if (++payload_count > mgr->max_payloads) {
+                       DRM_DEBUG_ATOMIC("[MST MGR:%p] state %p has too many 
payloads (max=%d)\n",
+                                        mgr, state, mgr->max_payloads);
+                       return -EINVAL;
+               }
        }
        DRM_DEBUG_ATOMIC("[MST MGR:%p] state %p vcpi avail=%d used=%d\n",
                         mgr, state, avail_slots, 63 - avail_slots);
-- 
2.17.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to