Hi, Yongqiang:
On Wed, 2019-03-27 at 14:18 +0800, yongqiang....@mediatek.com wrote:
> From: Yongqiang Niu <yongqiang....@mediatek.com>
>
> Update device tree binding documention for the display subsystem for
> Mediatek MT8183 SOCs
>
> Signed-off-by: Yongqiang Niu <yongqiang....@mediatek.com>
> ---
> .../bindings/display/mediatek/mediatek,disp.txt | 37
> ++++++++++++++--------
> 1 file changed, 23 insertions(+), 14 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> index 8469de5..5467470c 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> @@ -27,20 +27,23 @@
> Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt.
>
> Required properties (all function blocks):
> - compatible: "mediatek,<chip>-disp-<function>", one of
> - "mediatek,<chip>-disp-ovl" - overlay (4 layers, blending, csc)
> - "mediatek,<chip>-disp-rdma" - read DMA / line buffer
> - "mediatek,<chip>-disp-wdma" - write DMA
> - "mediatek,<chip>-disp-color" - color processor
> - "mediatek,<chip>-disp-aal" - adaptive ambient light controller
> - "mediatek,<chip>-disp-gamma" - gamma correction
> - "mediatek,<chip>-disp-merge" - merge streams from two RDMA sources
> - "mediatek,<chip>-disp-split" - split stream to two encoders
> - "mediatek,<chip>-disp-ufoe" - data compression engine
> - "mediatek,<chip>-dsi" - DSI controller, see mediatek,dsi.txt
> - "mediatek,<chip>-dpi" - DPI controller, see mediatek,dpi.txt
> - "mediatek,<chip>-disp-mutex" - display mutex
> - "mediatek,<chip>-disp-od" - overdrive
> - the supported chips are mt2701, mt2712 and mt8173.
> + "mediatek,<chip>-disp-ovl" - overlay (4 layers, blending,
> csc)
> + "mediatek,<chip>-disp-ovl-2l" - overlay (2 layers, blending,
> csc)
I prefer adding disp-ovl-2l to be an independent patch.
> + "mediatek,<chip>-disp-rdma" - read DMA / line buffer
> + "mediatek,<chip>-disp-wdma" - write DMA
> + "mediatek,<chip>-disp-ccorr" - color correction
I prefer adding disp-ccorr to be an independent patch.
> + "mediatek,<chip>-disp-color" - color processor
> + "mediatek,<chip>-disp-dither" - dither
I prefer adding disp-dither to be an independent patch.
> + "mediatek,<chip>-disp-aal" - adaptive ambient light
> controller
> + "mediatek,<chip>-disp-gamma" - gamma correction
> + "mediatek,<chip>-disp-merge" - merge streams from two RDMA
> sources
> + "mediatek,<chip>-disp-split" - split stream to two encoders
> + "mediatek,<chip>-disp-ufoe" - data compression engine
> + "mediatek,<chip>-dsi" - DSI controller, see
> mediatek,dsi.txt
> + "mediatek,<chip>-dpi" - DPI controller, see
> mediatek,dpi.txt
> + "mediatek,<chip>-disp-mutex" - display mutex
> + "mediatek,<chip>-disp-od" - overdrive
> + the supported chips are mt2701, mt2712, mt8173 and mt8183.
> - reg: Physical base address and length of the function block register space
> - interrupts: The interrupt signal from the function block (required, except
> for
> merge and split function blocks).
> @@ -71,6 +74,12 @@ mmsys: clock-controller@14000000 {
> #clock-cells = <1>;
> };
>
> +display_components: dispsys@14000000 {
> + compatible = "mediatek,mt8183-display";
"mediatek,mt8183-display" is undefined. I think this should be
"mediatek,mt8183-mmsys" and you have met the same problem in [1]. You
may depend on that series to develop your patches.
[1]
http://lists.infradead.org/pipermail/linux-mediatek/2018-November/015860.html
Regards,
CK
> + reg = <0 0x14000000 0 0x1000>;
> + power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> +};
> +
> ovl0: ovl@1400c000 {
> compatible = "mediatek,mt8173-disp-ovl";
> reg = <0 0x1400c000 0 0x1000>;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
