On Mon 2019-04-01 06:30:32, Brian Masney wrote:
> lm3630a_bank_a_update_status() and lm3630a_bank_b_update_status()
> both return the brightness value if the brightness was successfully
> updated. Writing to these attributes via sysfs would cause a 'Bad
> address' error to be returned. These functions should return 0 on
> success, so let's change it to correct that error.
>
> Signed-off-by: Brian Masney <masn...@onstation.org>
> Fixes: 28e64a68a2ef ("backlight: lm3630: apply chip revision")Acked-by: Pavel Machek <pa...@ucw.cz> > --- > drivers/video/backlight/lm3630a_bl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/lm3630a_bl.c > b/drivers/video/backlight/lm3630a_bl.c > index 2030a6b77a09..ef2553f452ca 100644 > --- a/drivers/video/backlight/lm3630a_bl.c > +++ b/drivers/video/backlight/lm3630a_bl.c > @@ -201,7 +201,7 @@ static int lm3630a_bank_a_update_status(struct > backlight_device *bl) > LM3630A_LEDA_ENABLE, LM3630A_LEDA_ENABLE); > if (ret < 0) > goto out_i2c_err; > - return bl->props.brightness; > + return 0; > > out_i2c_err: > dev_err(pchip->dev, "i2c failed to access\n"); > @@ -278,7 +278,7 @@ static int lm3630a_bank_b_update_status(struct > backlight_device *bl) > LM3630A_LEDB_ENABLE, LM3630A_LEDB_ENABLE); > if (ret < 0) > goto out_i2c_err; > - return bl->props.brightness; > + return 0; > > out_i2c_err: > dev_err(pchip->dev, "i2c failed to access REG_CTRL\n"); -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
