Hi Uma.

Some kerneldoc nits below.

        Sam

> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -599,6 +599,13 @@ struct drm_connector_state {
>        * and the connector bpc limitations obtained from edid.
>        */
>       u8 max_bpc;
> +
> +     /**
> +      * @metadata_blob_ptr:
> +      * DRM blob property for HDR output metadata
> +      */
> +     struct drm_property_blob *hdr_output_metadata_blob_ptr;

The kerneldoc comment uses the wrong name.

> +     u8 hdr_metadata_changed : 1;

kerneldoc is missing.

>  };
>  
>  /**
> @@ -1239,6 +1246,9 @@ struct drm_connector {
>        * &drm_mode_config.connector_free_work.
>        */
>       struct llist_node free_node;
> +
> +     /* HDR metdata */
> +     struct hdr_output_metadata hdr_metadata;
Please format as kerneldoc.
>  };
>  

>  #define obj_to_connector(x) container_of(x, struct drm_connector, base)
> diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
> index 7f60e8e..ef2656b 100644
> --- a/include/drm/drm_mode_config.h
> +++ b/include/drm/drm_mode_config.h
> @@ -836,6 +836,12 @@ struct drm_mode_config {
>        */
>       struct drm_property *writeback_out_fence_ptr_property;
>  
> +     /*
> +      * hdr_metadata_property: Connector property containing hdr metatda
> +      * This will be provided by userspace compositors based on HDR content
> +      */
> +     struct drm_property *hdr_output_metadata_property;
> +
kerneldoc comment uses wrong name

>       /* dumb ioctl parameters */
>       uint32_t preferred_depth, prefer_shadow;
Please format as kerneldoc.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to