On Mon, May 27, 2019 at 08:13:06AM +0200, Daniel Vetter wrote: > On Sat, May 25, 2019 at 05:01:59PM +0200, Sam Ravnborg wrote: > > Hi Daniel > > > > > It's dead code, and removing it avoids me having to understand > > > what it's doing with lock_fb_info. > > > > I pushed the series through my build tests which include the sh > > architecture. > > > > One error and one warning was triggered from sh_mobile_lcdcfb.c. > > The rest was fine. > > > > The patch below removed the sole user of > > sh_mobile_lcdc_must_reconfigure() so this triggers a warning. > > > > And I also get the following error: > > drivers/video/fbdev/sh_mobile_lcdcfb.c: In function ‘sh_mobile_fb_reconfig’: > > drivers/video/fbdev/sh_mobile_lcdcfb.c:1800:2: error: implicit declaration > > of function ‘fbcon_update_vcs’; did you mean ‘file_update_time’? > > [-Werror=implicit-function-declaration] > > fbcon_update_vcs(info, true); > > ^~~~~~~~~~~~~~~~ > > file_update_time > > > > I did not check but assume the error was triggered in patch 28 where > > fbcon_update_vcs() in introduced. > > Oops. Can I have your sob so I can squash this in? Yes, here we go. (It was trivial so I thought not needed, sorry) Signed-off-by: Sam Ravnborg <s...@ravnborg.org>
- [PATCH 12/33] fbdev/omap: sysfs files can't disappear before... Daniel Vetter
- [PATCH 07/33] fbdev/aty128fb: Remove dead code Daniel Vetter
- [PATCH 05/33] fbdev/sa1100fb: Remove dead code Daniel Vetter
- [PATCH 08/33] fbcon: s/struct display/struct fbcon_display/ Daniel Vetter
- [PATCH 02/33] fbdev: locking check for fb_set_suspend Daniel Vetter
- [PATCH 03/33] vt: might_sleep() annotation for do_blank_scre... Daniel Vetter
- [PATCH 06/33] fbdev/cyber2000: Remove struct display Daniel Vetter
- [PATCH 11/33] fbdev/sh_mobile: remove sh_mobile_lcdc_display... Daniel Vetter
- Re: [PATCH 11/33] fbdev/sh_mobile: remove sh_mobile_lcd... Sam Ravnborg
- Re: [PATCH 11/33] fbdev/sh_mobile: remove sh_mobile... Daniel Vetter
- Re: [PATCH 11/33] fbdev/sh_mobile: remove sh_mo... Sam Ravnborg
- [PATCH 21/33] fbdev: directly call fbcon_suspended/resumed Daniel Vetter
- [PATCH 33/33] backlight: simplify lcd notifier Daniel Vetter
- [PATCH 13/33] fbdev: sysfs files can't disappear before the ... Daniel Vetter
- [PATCH 09/33] fbcon: Remove fbcon_has_exited Daniel Vetter
- Re: [PATCH 09/33] fbcon: Remove fbcon_has_exited Sam Ravnborg
- Re: [PATCH 09/33] fbcon: Remove fbcon_has_exited Daniel Vetter
- Re: [PATCH 09/33] fbcon: Remove fbcon_has_exite... Sam Ravnborg
- [PATCH 15/33] fbdev/atyfb: lock_fb_info can't fail Daniel Vetter
- [PATCH 29/33] vgaswitcheroo: call fbcon_remap_all directly Daniel Vetter
- [PATCH 32/33] staging/olpc_dcon: Add drm conversion to TODO Daniel Vetter