On Mon, 3 Jun 2019 16:28:48 +0200 Daniel Vetter <daniel.vet...@ffwll.ch> wrote:
> drm_atomic_set_fence_for_plane() contains the main discussion from a
> driver pov, link to that from more places.
>
> Cc: Pekka Paalanen <pekka.paala...@collabora.com>
> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
> Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
> Cc: Maxime Ripard <maxime.rip...@bootlin.com>
> Cc: Sean Paul <s...@poorly.run>
> Cc: David Airlie <airl...@linux.ie>
> Cc: Daniel Vetter <dan...@ffwll.ch>
> ---
> drivers/gpu/drm/drm_gem_framebuffer_helper.c | 6 ++++++
> include/drm/drm_plane.h | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> index 6fd48efe288c..6791245963c3 100644
> --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
> @@ -284,6 +284,9 @@ EXPORT_SYMBOL_GPL(drm_gem_fb_create_with_dirty);
> * There is no need for &drm_plane_helper_funcs.cleanup_fb hook for simple
> * gem based framebuffer drivers which have their buffers always pinned in
> * memory.
> + *
> + * See drm_atomic_set_fence_for_plane() for a discussion of implicit and
> + * explicit fencing in atomic modeset updates.
> */
> int drm_gem_fb_prepare_fb(struct drm_plane *plane,
> struct drm_plane_state *state)
> @@ -314,6 +317,9 @@ EXPORT_SYMBOL_GPL(drm_gem_fb_prepare_fb);
> * &dma_buf attached, extracts the exclusive fence and attaches it to plane
> * state for the atomic helper to wait on. Drivers can use this as their
> * &drm_simple_display_pipe_funcs.prepare_fb callback.
> + *
> + * See drm_atomic_set_fence_for_plane() for a discussion of implicit and
> + * explicit fencing in atomic modeset updates.
> */
> int drm_gem_fb_simple_display_pipe_prepare_fb(struct drm_simple_display_pipe
> *pipe,
> struct drm_plane_state
> *plane_state)
> diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
> index 6078c700d9ba..cd5903ad33f7 100644
> --- a/include/drm/drm_plane.h
> +++ b/include/drm/drm_plane.h
> @@ -69,7 +69,7 @@ struct drm_plane_state {
> *
> * Optional fence to wait for before scanning out @fb. The core atomic
> * code will set this when userspace is using explicit fencing. Do not
> - * write this directly for a driver's implicit fence, use
> + * write this field directly for a driver's implicit fence, use
> * drm_atomic_set_fence_for_plane() to ensure that an explicit fence is
> * preserved.
> *
Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.com>
FWIW
Thanks!
pq
pgp5fF11uiGT9.pgp
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
