Am 02.07.19 um 19:15 schrieb Emil Velikov:
On Fri, 14 Jun 2019 at 19:02, Koenig, Christian
<christian.koe...@amd.com> wrote:
Am 14.06.19 um 19:33 schrieb Emil Velikov:
From: Emil Velikov <emil.veli...@collabora.com>

Currently the AMDGPU_CTX_PRIORITY_* defines are used in both
drm_amdgpu_ctx_in::priority and drm_amdgpu_sched_in::priority.

Extend the comment to mention the CAP_SYS_NICE or DRM_MASTER requirement
is only applicable with the former.

Cc: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl>
Cc: Christian König <christian.koe...@amd.com>
Cc: Alex Deucher <alexander.deuc...@amd.com>
Signed-off-by: Emil Velikov <emil.veli...@collabora.com>
---
Mildly curious: why didn't one extend ctx_amdgpu_ctx instead of adding
drm_amdgpu_sched? New flag + _u32 fd at the end (for the former) would
have been enough (and tweaking the ioctl permission thingy).
The drm_amdgpu_sched is only allowed for DRM_MASTER.

Fair enough.

Is the patch wrong or did it slip through the cracks? I cannot see it
in Alex's tree.

Looks like Alex just missed this one and I was on vacation/out of office for a while.

I've gone ahead added my rb and just pushed it.

Thanks,
Christian.


-Emil
_______________________________________________
amd-gfx mailing list
amd-...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to