I have tested these changes on an ili9486-based display connected through SPI to a raspberry pi and can confirm they work in combination with another patch I'll send shortly.
Regards, Jan On July 11, 2019, 8:31 a.m., Phil Reid wrote: > Conversion to use gpio descriptors broke all gpio lookups as > devm_gpiod_get_index was converted to use dev->driver->name for > the gpio name lookup. Fix this by using the name param. In > addition gpiod_get post-fixes the -gpios to the name so that > shouldn't be included in the call. However this then breaks the > of_find_property call to see if the gpio entry exists as all > fbtft treats all gpios as optional. So use devm_gpiod_get_index_optional > instead which achieves the same thing and is simpler. > > Nishad confirmed the changes where only ever compile tested. > > Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor > interface") > Signed-off-by: Phil Reid <pr...@electromag.com.au> > --- > drivers/staging/fbtft/fbtft-core.c | 39 > ++++++++++++++++++-------------------- > 1 file changed, 18 insertions(+), 21 deletions(-) Tested-by: Jan Sebastian Götte <li...@jaseg.net> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel