On Thu, Oct 10, 2019 at 2:55 AM Ben Dooks <ben.do...@codethink.co.uk> wrote: > > The drm_sched_fence_ops_{scheduled,finished} are not exported > from the file so make them static to avoid the following > warnings from sparse: > > drivers/gpu/drm/scheduler/sched_fence.c:131:28: warning: symbol > 'drm_sched_fence_ops_scheduled' was not declared. Should it be static? > drivers/gpu/drm/scheduler/sched_fence.c:137:28: warning: symbol > 'drm_sched_fence_ops_finished' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.do...@codethink.co.uk>
Reviewed and pushed out to drm-misc-next. Thanks! Alex > --- > Cc: David Airlie <airl...@linux.ie> > Cc: Daniel Vetter <dan...@ffwll.ch> > Cc: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/scheduler/sched_fence.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/scheduler/sched_fence.c > b/drivers/gpu/drm/scheduler/sched_fence.c > index 54977408f574..8b45c3a1b84e 100644 > --- a/drivers/gpu/drm/scheduler/sched_fence.c > +++ b/drivers/gpu/drm/scheduler/sched_fence.c > @@ -128,13 +128,13 @@ static void drm_sched_fence_release_finished(struct > dma_fence *f) > dma_fence_put(&fence->scheduled); > } > > -const struct dma_fence_ops drm_sched_fence_ops_scheduled = { > +static const struct dma_fence_ops drm_sched_fence_ops_scheduled = { > .get_driver_name = drm_sched_fence_get_driver_name, > .get_timeline_name = drm_sched_fence_get_timeline_name, > .release = drm_sched_fence_release_scheduled, > }; > > -const struct dma_fence_ops drm_sched_fence_ops_finished = { > +static const struct dma_fence_ops drm_sched_fence_ops_finished = { > .get_driver_name = drm_sched_fence_get_driver_name, > .get_timeline_name = drm_sched_fence_get_timeline_name, > .release = drm_sched_fence_release_finished, > -- > 2.23.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel