Hi Nicolas, On 23/12/19 10:14, Nicolas Boichat wrote: > On Mon, Dec 23, 2019 at 3:10 PM Enric Balletbo i Serra > <enric.balle...@collabora.com> wrote: >> >> Hi Nicolas, >> >> Many thanks for you review. Just preparing a new version with your comments >> addressed. >> >> On 20/12/19 9:44, Nicolas Boichat wrote: >>> On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra >>> <enric.balle...@collabora.com> wrote: >>>> >>>> From: Jitao Shi <jitao....@mediatek.com> >>>> >>>> This patch adds drm_bridge driver for parade DSI to eDP bridge chip. >>>> >>>> Signed-off-by: Jitao Shi <jitao....@mediatek.com> >>>> Reviewed-by: Daniel Kurtz <djku...@chromium.org> >>>> Reviewed-by: Enric Balletbo i Serra <enric.balle...@collabora.com> >>>> [uli: followed API changes, removed FW update feature] >>>> Signed-off-by: Ulrich Hecht <u...@fpond.eu> >>>> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> >>>> --- >> [snip] >>>> + ret = i2c_smbus_write_byte_data(client, PAGE2_MCS_EN, >>>> + status & ~MCS_EN); >>>> + if (ret < 0) { >>>> + DRM_ERROR("failed write PAGE2_MCS_EN: %d\n", ret); >>>> + goto err_regulators_disable; >>>> + } >>>> + >>>> + ret = ps8640_bridge_unmute(ps_bridge); >>>> + if (ret) >>>> + DRM_ERROR("failed to enable unmutevideo: %d\n", ret); >>> >>> failed to unmute? Or failed to enable? >>> >> >> failed to unmute sound more clear to me. > > I may be wrong, but I have the feeling that the functions > "mute/unmute" video/display, actually... And that the function naming > is strange... >
Yes, that's strange. > You could just try to remove the calls, as there is no audio on the > board you have (elm), so if video still works, maybe this is actually > audio ,-) > And without those the display doesn't work. So I suspect that what is wrong and confusing is the message, instead of mute/unmute, and based on the register names this looks more like an internal regulator that you need to enable and disable, so I'll change the error message accordingly. Thanks, Enric > Thanks, > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel