Re: [PATCH 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01

[Sam Ravnborg]

Hi Michael.

On Sun, Jan 26, 2020 at 07:39:10PM +0100, michael.s...@seznam.cz wrote:
> From: Michael Srba <michael.s...@seznam.cz>
> 
> This patch adds dts bindings for Samsung AMS452EF01 AMOLED panel, which makes
> use of their S6E88A0 controller.
> 
> Signed-off-by: Michael Srba <michael.s...@seznam.cz>
New bindings files for panels must be in DT schema format (.yaml).

Please see other bindings as examples.
Your example uses GPIO_ACTIVE_HIGH, so rememeber to include the
relevant header file in your example to get the definition.

        Sam

> ---
>  .../panel/samsung,s6e88a0-ams452ef01.txt      | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.txt
> 
> diff --git 
> a/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.txt
>  
> b/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.txt
> new file mode 100644
> index 000000000000..2dcf9580febd
> --- /dev/null
> +++ 
> b/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.txt
> @@ -0,0 +1,26 @@
> +Samsung AMS452EF01 AMOLED panel with S6E88A0 video mode controller.
> +
> +Required properties:
> +  - compatible: "samsung,s6e88a0-ams452ef01"
> +  - reg: the virtual channel number of a DSI peripheral
> +  - vdd3-supply: core voltage supply
> +  - vci-supply: voltage supply for analog circuits
> +  - reset-gpios: a GPIO spec for the reset pin
> +
> +The device node can contain one 'port' child node with one child
> +'endpoint' node, according to the bindings defined in [1]. This
> +node should describe panel's video bus.
> +
> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example:
> +
> +     panel@0 {
> +             reg = <0>;
> +
> +             compatible = "samsung,s6e88a0-ams452ef01";
> +
> +             vdd3-supply = <&pm8916_l17>;
> +             vci-supply = <&reg_vlcd_vci>;
> +             reset-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
> +     };
> -- 
> 2.24.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel