[PATCH 13/21] drm/omapdrm: remove checks for return value of drm_debugfs functions.

[Wambui Karuga]

Since 987d65d01356 (drm: debugfs: make
drm_debugfs_create_files() never fail), there is no need to ever check
the return value for drm_debugfs_create_files(). Therefore remove the
checks for the return value and subsequent error handling in
omap_debugfs_init().

These changes also enables the changing of omap_debugfs_init() to return
void.

Signed-off-by: Wambui Karuga <wambui.karu...@gmail.com>
---
 drivers/gpu/drm/omapdrm/omap_debugfs.c | 29 +++++++-------------------
 drivers/gpu/drm/omapdrm/omap_drv.h     |  2 +-
 2 files changed, 8 insertions(+), 23 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/omap_debugfs.c 
b/drivers/gpu/drm/omapdrm/omap_debugfs.c
index 34dfb33145b4..b57fbe8a0ac2 100644
--- a/drivers/gpu/drm/omapdrm/omap_debugfs.c
+++ b/drivers/gpu/drm/omapdrm/omap_debugfs.c
@@ -80,31 +80,16 @@ static struct drm_info_list omap_dmm_debugfs_list[] = {
        {"tiler_map", tiler_map_show, 0},
 };
 
-int omap_debugfs_init(struct drm_minor *minor)
+void omap_debugfs_init(struct drm_minor *minor)
 {
-       struct drm_device *dev = minor->dev;
-       int ret;
-
-       ret = drm_debugfs_create_files(omap_debugfs_list,
-                       ARRAY_SIZE(omap_debugfs_list),
-                       minor->debugfs_root, minor);
-
-       if (ret) {
-               dev_err(dev->dev, "could not install omap_debugfs_list\n");
-               return ret;
-       }
+       drm_debugfs_create_files(omap_debugfs_list,
+                                ARRAY_SIZE(omap_debugfs_list),
+                                minor->debugfs_root, minor);
 
        if (dmm_is_available())
-               ret = drm_debugfs_create_files(omap_dmm_debugfs_list,
-                               ARRAY_SIZE(omap_dmm_debugfs_list),
-                               minor->debugfs_root, minor);
-
-       if (ret) {
-               dev_err(dev->dev, "could not install omap_dmm_debugfs_list\n");
-               return ret;
-       }
-
-       return ret;
+               drm_debugfs_create_files(omap_dmm_debugfs_list,
+                                        ARRAY_SIZE(omap_dmm_debugfs_list),
+                                        minor->debugfs_root, minor);
 }
 
 #endif
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h 
b/drivers/gpu/drm/omapdrm/omap_drv.h
index 7c4b66efcaa7..8a1fac680138 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.h
+++ b/drivers/gpu/drm/omapdrm/omap_drv.h
@@ -82,6 +82,6 @@ struct omap_drm_private {
 };
 
 
-int omap_debugfs_init(struct drm_minor *minor);
+void omap_debugfs_init(struct drm_minor *minor);
 
 #endif /* __OMAPDRM_DRV_H__ */
-- 
2.25.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel