Hi Sam, Thank you for the patch.
On Fri, Jul 03, 2020 at 09:24:05PM +0200, Sam Ravnborg wrote: > Display drivers are in the new model expected to create > the connector using drm_bridge_connector_init(). > Allow users of this bridge driver to support the new > model by introducing support for optional connector creation. > > Signed-off-by: Sam Ravnborg <[email protected]> > Cc: Andrzej Hajda <[email protected]> > Cc: Neil Armstrong <[email protected]> > Cc: Laurent Pinchart <[email protected]> > Cc: Jonas Karlman <[email protected]> > Cc: Jernej Skrabec <[email protected]> > --- > drivers/gpu/drm/bridge/tc358767.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358767.c > b/drivers/gpu/drm/bridge/tc358767.c > index fb9d57967b2c..2eb00d39f619 100644 > --- a/drivers/gpu/drm/bridge/tc358767.c > +++ b/drivers/gpu/drm/bridge/tc358767.c > @@ -1421,8 +1421,7 @@ static int tc_bridge_attach(struct drm_bridge *bridge, > } > > if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) { > - DRM_ERROR("Fix bridge driver to make connector optional!"); > - return -EINVAL; > + return 0; > } I'd drop the braces too. Reviewed-by: Laurent Pinchart <[email protected]> > > /* Create DP/eDP connector */ -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
