>>> +++ b/drivers/video/backlight/sky81452-backlight.c
>>> @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data
>>> *sky81452_bl_parse_dt(
>>> num_entry);
>>> if (ret < 0) {
>>> dev_err(dev, "led-sources node is invalid.\n");
>>> + of_node_put(np);
>>> return ERR_PTR(-EINVAL);
>>> }
>>
>> I propose to add the jump target “put_node” so that a bit of common exception
>> handling code can be better reused at the end of this function
>> implementation.
…
> You can safely ignore any review comments from Markus!
How does this feedback fit to the Linux coding style?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n475
Regards,
Markus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
