The cat is somewhat out of the bag already.. so I took the approach of making the more useful of the traces for visualization (freq_change trace) identical to the i915 one in units and format, so userspace just has to add another event name to a list, and not have to add more parsing code.
But the bigger problem is that it doesn't seem possible to #include multiple foo_trace.h's in a single C file, so I'm not seeing how it is possible to have both generic and driver specific traces. BR, -R On Tue, Sep 1, 2020 at 11:52 PM Tomeu Vizoso <tomeu.viz...@collabora.com> wrote: > > Hi Rob, > > Do you think we could make all these generic? Visualization tools will need > to do some processing so these can be neatly presented and it could be far > more convenient if people wouldn't need to add code for each GPU driver. > > Maybe we could put all these tracepoints in DRM core as they seem useful to > all drivers? > > Thanks, > > Tomeu > > On Tue, 1 Sep 2020 at 17:41, Rob Clark <robdcl...@gmail.com> wrote: >> >> From: Rob Clark <robdcl...@chromium.org> >> >> Various extra tracepoints that I've been collecting. >> >> Rob Clark (3): >> drm/msm/gpu: Add GPU freq_change traces >> drm/msm: Convert shrinker msgs to tracepoints >> drm/msm/gpu: Add suspend/resume tracepoints >> >> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 3 + >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 ++ >> drivers/gpu/drm/msm/msm_gem_shrinker.c | 5 +- >> drivers/gpu/drm/msm/msm_gpu.c | 4 ++ >> drivers/gpu/drm/msm/msm_gpu_trace.h | 83 ++++++++++++++++++++++++++ >> 5 files changed, 97 insertions(+), 2 deletions(-) >> >> -- >> 2.26.2 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
