On Tue, Oct 27, 2020 at 5:50 PM Arnd Bergmann <a...@kernel.org> wrote: > > On Tue, Oct 27, 2020 at 10:54 AM Patrik Jakobsson > <patrik.r.jakobs...@gmail.com> wrote: > > On Tue, Oct 27, 2020 at 10:33 AM Daniel Vetter <dan...@ffwll.ch> wrote: > > > On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote: > > > > From: Arnd Bergmann <a...@arndb.de> > > > > > > > > gcc -Wextra notices that one of the fields in psbfb_roll_ops has two > > > > initializers: > > > > > > > > drivers/gpu/drm/gma500/framebuffer.c:185:20: warning: initialized field > > > > overwritten [-Woverride-init] > > > > > > > > Open-code this instead, leaving out the extraneous initializers for > > > > .fb_pan_display. > > > > > > > > Fixes: 3da6c2f3b730 ("drm/gma500: use DRM_FB_HELPER_DEFAULT_OPS for > > > > fb_ops") > > > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > > > > > > Scrollback is dead, so I'm not sure it's even worth to keep all this. I'd > > > just garbage-collect this, maybe als the entire accelerator code and just > > > leave psbfb_unaccel_ops behind ... > > > -Daniel > > > > That's been my idea for quite some time. The gtt roll code is also > > broken in multi display setups. > > > > Arnd, I can take care of this unless you feel an urge to do it yourself. > > That would be good, thanks
Should be fixed with: https://patchwork.freedesktop.org/patch/397482/?series=83153&rev=1 > > I have no specific interest in the drm drivers, this is just part of a > larger work to enable more of the W=1 options across the kernel > by default, after all the existing warnings are addressed. > > Arnd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel