Fix the following coccinelle report:
./drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c:1367:3-5:
WARNING: possible condition with no effect (if == else)
Both branches are the same, so remove the if/else altogether.
Fixes: 81875979f0b2 ("drm/amd/display: Remove extra pairs of parentheses in
dce_calcs.c")
Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Zou Wei <zou_...@huawei.com>
---
drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
index 2c6db37..e4f29cd 100644
--- a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
+++ b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
@@ -1364,13 +1364,10 @@ static void calculate_bandwidth(
/*if stutter and dram clock state change are gated before cursor then
the cursor latency hiding does not limit stutter or dram clock state change*/
for (i = 0; i <= maximum_number_of_surfaces - 1; i++) {
if (data->enable[i]) {
- if
(dceip->graphics_lb_nodownscaling_multi_line_prefetching == 1) {
- data->maximum_latency_hiding[i] =
bw_add(data->minimum_latency_hiding[i], bw_mul(bw_frc_to_fixed(5, 10),
data->total_dmifmc_urgent_latency));
- }
- else {
- /*maximum_latency_hiding(i) =
minimum_latency_hiding(i) + 1 / vsr(i) * h_total(i) / pixel_rate(i) + 0.5 *
total_dmifmc_urgent_latency*/
- data->maximum_latency_hiding[i] =
bw_add(data->minimum_latency_hiding[i], bw_mul(bw_frc_to_fixed(5, 10),
data->total_dmifmc_urgent_latency));
- }
+ /*maximum_latency_hiding(i) = minimum_latency_hiding(i)
+ 1 / vsr(i) **/
+ /* h_total(i) / pixel_rate(i) + 0.5 *
total_dmifmc_urgent_latency*/
+ data->maximum_latency_hiding[i] =
bw_add(data->minimum_latency_hiding[i],
+ bw_mul(bw_frc_to_fixed(5, 10),
data->total_dmifmc_urgent_latency));
data->maximum_latency_hiding_with_cursor[i] =
bw_min2(data->maximum_latency_hiding[i], data->cursor_latency_hiding[i]);
}
}
--
2.6.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
