On Sun, Nov 01, 2020 at 09:49:04AM -0500, Peilin Ye wrote: > Replace printk() with pr_err(), pr_warn() and pr_info(). Do not split long > strings, for easier grepping. Use `__func__` whenever applicable. > > fbcon_prepare_logo() has more than one callers, use "fbcon_prepare_logo:" > instead of "fbcon_init:", for less confusion. > > Suggested-by: Sam Ravnborg <s...@ravnborg.org> > Signed-off-by: Peilin Ye <yepeilin...@gmail.com> > --- > drivers/video/fbdev/core/fbcon.c | 42 +++++++++++++------------------- > 1 file changed, 17 insertions(+), 25 deletions(-) > > diff --git a/drivers/video/fbdev/core/fbcon.c > b/drivers/video/fbdev/core/fbcon.c > index cef437817b0d..a3e87ab0e523 100644 > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -659,8 +659,7 @@ static void fbcon_prepare_logo(struct vc_data *vc, struct > fb_info *info, > > if (logo_lines > vc->vc_bottom) { > logo_shown = FBCON_LOGO_CANSHOW; > - printk(KERN_INFO > - "fbcon_init: disable boot-logo (boot-logo bigger than > screen).\n"); > + pr_info("%s: disable boot-logo (boot-logo bigger than > screen).\n", __func__);
Shouldn't this be: dev_info(info->dev, "..."); instead? It's a driver, and you have access to the struct device that is being worked on, so always try to use the dev_* versions of these calls instead when ever possible. thanks, greg k-h _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel