On 11/20/20 12:28, Joe Perches wrote: > On Fri, 2020-11-20 at 12:21 -0600, Gustavo A. R. Silva wrote: >> Hi all, >> >> This series aims to fix almost all remaining fall-through warnings in >> order to enable -Wimplicit-fallthrough for Clang. >> >> In preparation to enable -Wimplicit-fallthrough for Clang, explicitly >> add multiple break/goto/return/fallthrough statements instead of just >> letting the code fall through to the next case. >> >> Notice that in order to enable -Wimplicit-fallthrough for Clang, this >> change[1] is meant to be reverted at some point. So, this patch helps >> to move in that direction. > > This was a bit hard to parse for a second or three. > > Thanks Gustavo. > > How was this change done? I audited case by case in order to determine the best fit for each situation. Depending on the surrounding logic, sometimes it makes more sense a goto or a fallthrough rather than merely a break. Thanks -- Gustavo _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
- [PATCH 000/141] Fix fall-through warnings for Clang Gustavo A. R. Silva
- [PATCH 005/141] drm/radeon: Fix fall-through warn... Gustavo A. R. Silva
- Re: [PATCH 005/141] drm/radeon: Fix fall-thro... Alex Deucher
- [PATCH 004/141] drm/amdgpu: Fix fall-through warn... Gustavo A. R. Silva
- Re: [PATCH 004/141] drm/amdgpu: Fix fall-thro... Alex Deucher
- Re: [PATCH 004/141] drm/amdgpu: Fix fall-... Gustavo A. R. Silva
- [PATCH 028/141] drm/amd/display: Fix fall-through... Gustavo A. R. Silva
- Re: [PATCH 028/141] drm/amd/display: Fix fall... Alex Deucher
- Re: [PATCH 028/141] drm/amd/display: Fix ... Gustavo A. R. Silva
- Re: [PATCH 000/141] Fix fall-through warnings for... Joe Perches
- Re: [PATCH 000/141] Fix fall-through warnings... Gustavo A. R. Silva
- [PATCH 078/141] drm/amd/pm: Fix fall-through warn... Gustavo A. R. Silva
- Re: [PATCH 078/141] drm/amd/pm: Fix fall-thro... Alex Deucher
- [PATCH 082/141] drm/nouveau: Fix fall-through war... Gustavo A. R. Silva
- [PATCH 083/141] drm/nouveau/therm: Fix fall-throu... Gustavo A. R. Silva
- [PATCH 079/141] drm: Fix fall-through warnings fo... Gustavo A. R. Silva
- Re: [PATCH 079/141] drm: Fix fall-through war... Sam Ravnborg
- Re: [PATCH 079/141] drm: Fix fall-through... Gustavo A. R. Silva
- [PATCH 080/141] drm/i915/gem: Fix fall-through wa... Gustavo A. R. Silva
- [PATCH 084/141] drm/via: Fix fall-through warning... Gustavo A. R. Silva
- Re: [PATCH 084/141] drm/via: Fix fall-through... Sam Ravnborg