On Fri, 2020-11-27 at 20:57 +0100, Sam Ravnborg wrote:
> Replacing DPRINTK() statements with pr_debug fixes
> W=1 warnings.
> And moves to a more standard logging setup at the same time.
[]
> diff --git a/drivers/video/fbdev/core/fbcon.c
> b/drivers/video/fbdev/core/fbcon.c
[]
> @@ -1015,9 +1007,9 @@ static const char *fbcon_startup(void)
> rows /= vc->vc_font.height;
> vc_resize(vc, cols, rows);
>
>
> - DPRINTK("mode: %s\n", info->fix.id);
> - DPRINTK("visual: %d\n", info->fix.visual);
> - DPRINTK("res: %dx%d-%d\n", info->var.xres,
> + pr_debug("mode: %s\n", info->fix.id);
> + pr_debug("visual: %d\n", info->fix.visual);
> + pr_debug("res: %dx%d-%d\n", info->var.xres,
> info->var.yres,
> info->var.bits_per_pixel);
It'd be nicer to reindent the subsequent lines too.
> @@ -3299,7 +3291,7 @@ static void fbcon_exit(void)
>
>
> if (info->queue.func)
> pending = cancel_work_sync(&info->queue);
> - DPRINTK("fbcon: %s pending work\n", (pending ? "canceled" :
> + pr_debug("fbcon: %s pending work\n", (pending ? "canceled" :
> "no"));
perhaps:
pr_debug("fbcon: %s pending work\n", pending ? "canceled" :
"no");
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
