eb_copy_relocations() only do unsafe_put_user(), it only
requires write access to user.

Use user_write_access_begin() instead of user_access_begin().

Signed-off-by: Christophe Leroy <christophe.le...@csgroup.eu>
---
 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c 
b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index d70ca36f74f6..eb7a4bfd53ef 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -1851,14 +1851,14 @@ static int eb_copy_relocations(const struct 
i915_execbuffer *eb)
                 * happened we would make the mistake of assuming that the
                 * relocations were valid.
                 */
-               if (!user_access_begin(urelocs, size))
+               if (!user_write_access_begin(urelocs, size))
                        goto end;
 
                for (copied = 0; copied < nreloc; copied++)
                        unsafe_put_user(-1,
                                        &urelocs[copied].presumed_offset,
                                        end_user);
-               user_access_end();
+               user_write_access_end();
 
                eb->exec[i].relocs_ptr = (uintptr_t)relocs;
        }
@@ -1866,7 +1866,7 @@ static int eb_copy_relocations(const struct 
i915_execbuffer *eb)
        return 0;
 
 end_user:
-       user_access_end();
+       user_write_access_end();
 end:
        kvfree(relocs);
        err = -EFAULT;
-- 
2.25.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to