Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Tian Tao <[email protected]> --- drivers/gpu/host1x/mipi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c index 2efe12d..4ba022f 100644 --- a/drivers/gpu/host1x/mipi.c +++ b/drivers/gpu/host1x/mipi.c @@ -523,10 +523,9 @@ static int tegra_mipi_probe(struct platform_device *pdev) mutex_init(&mipi->lock); mipi->clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(mipi->clk)) { - dev_err(&pdev->dev, "failed to get clock\n"); - return PTR_ERR(mipi->clk); - } + if (IS_ERR(mipi->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(mipi->clk), + "failed to get clock\n"); err = clk_prepare(mipi->clk); if (err < 0) -- 2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
