Re: [PATCH v8 1/5] drm/ast: Remove reference to struct drm_device.pdev

[Thomas Zimmermann]

Hi

Am 29.04.21 um 18:04 schrieb Ruhl, Michael J:

-----Original Message-----
From: dri-devel <dri-devel-boun...@lists.freedesktop.org> On Behalf Of
Thomas Zimmermann
Sent: Thursday, April 29, 2021 6:51 AM
To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; Vivi, Rodrigo
<rodrigo.v...@intel.com>; airl...@linux.ie; dan...@ffwll.ch; chris@chris-
wilson.co.uk
Cc: lkp <l...@intel.com>; intel-...@lists.freedesktop.org; dri-
de...@lists.freedesktop.org; Thomas Zimmermann
<tzimmerm...@suse.de>; Dave Airlie <airl...@redhat.com>
Subject: [PATCH v8 1/5] drm/ast: Remove reference to struct
drm_device.pdev

Using struct drm_device.pdev is deprecated. Upcast with to_pci_dev()
from struct drm_device.dev to get the PCI device structure.

Reviewed-by: Michael J. Ruhl <michael.j.r...@intel.com>

Best regards
Thomas

Awesome! Thanks a lot for the timely response. I pushed everything into drm-misc-next before the bitrot sets in again.

m

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
Fixes: ba4e0339a6a3 ("drm/ast: Fixed CVE for DP501")
Cc: KuoHsiang Chou <kuohsiang_c...@aspeedtech.com>
Cc: kernel test robot <l...@intel.com>
Cc: Thomas Zimmermann <tzimmerm...@suse.de>
Cc: Dave Airlie <airl...@redhat.com>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/ast/ast_main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/ast/ast_main.c
b/drivers/gpu/drm/ast/ast_main.c
index 189d783f6e2c..6b49a92dc75f 100644
--- a/drivers/gpu/drm/ast/ast_main.c
+++ b/drivers/gpu/drm/ast/ast_main.c
@@ -411,7 +411,6 @@ struct ast_private *ast_device_create(const struct
drm_driver *drv,
                return ast;
        dev = &ast->base;

-       dev->pdev = pdev;
        pci_set_drvdata(pdev, dev);

        ast->regs = pcim_iomap(pdev, 1, 0);
--
2.31.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel