Hi Mark,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tegra-drm/drm/tegra/for-next]
[also build test WARNING on linus/master v5.13-rc4 next-20210604]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Mark-Yacoub/Verify-Gamma-Degamma-LUT-sizes-in-amdgpu_dm_atomic_check/20210605-010052
base:   git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/0day-ci/linux/commit/69d2510b404de1ebb3ee54e37daff71f1df02a29
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Mark-Yacoub/Verify-Gamma-Degamma-LUT-sizes-in-amdgpu_dm_atomic_check/20210605-010052
        git checkout 69d2510b404de1ebb3ee54e37daff71f1df02a29
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_color.c:288: 
>> warning: This comment starts with '/**', but isn't a kernel-doc comment. 
>> Refer Documentation/doc-guide/kernel-doc.rst
    * Verifies that the Degamma and Gamma LUTs attached to the |crtc_state| are 
of


vim +288 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_color.c

   286  
   287  /**
 > 288   * Verifies that the Degamma and Gamma LUTs attached to the 
 > |crtc_state| are of
   289   * the expected size.
   290   * Returns 0 on success.
   291   */
   292  int amdgpu_dm_verify_lut_sizes(const struct drm_crtc_state *crtc_state)
   293  {
   294          const struct drm_color_lut *lut = NULL;
   295          uint32_t size = 0;
   296  
   297          lut = __extract_blob_lut(crtc_state->degamma_lut, &size);
   298          if (lut && size != MAX_COLOR_LUT_ENTRIES) {
   299                  DRM_DEBUG_DRIVER(
   300                          "Invalid Degamma LUT size. Should be %u but got 
%u.\n",
   301                          MAX_COLOR_LUT_ENTRIES, size);
   302                  return -EINVAL;
   303          }
   304  
   305          lut = __extract_blob_lut(crtc_state->gamma_lut, &size);
   306          if (lut && size != MAX_COLOR_LUT_ENTRIES &&
   307              size != MAX_COLOR_LEGACY_LUT_ENTRIES) {
   308                  DRM_DEBUG_DRIVER(
   309                          "Invalid Gamma LUT size. Should be %u (or %u 
for legacy) but got %u.\n",
   310                          MAX_COLOR_LUT_ENTRIES, 
MAX_COLOR_LEGACY_LUT_ENTRIES,
   311                          size);
   312                  return -EINVAL;
   313          }
   314  
   315          return 0;
   316  }
   317  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to