convert list_for_each() to list_for_each_entry() where
applicable.

Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Zou Wei <zou_...@huawei.com>
---
 drivers/video/fbdev/core/fbsysfs.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/core/fbsysfs.c 
b/drivers/video/fbdev/core/fbsysfs.c
index 65dae05..753ecc8 100644
--- a/drivers/video/fbdev/core/fbsysfs.c
+++ b/drivers/video/fbdev/core/fbsysfs.c
@@ -130,14 +130,12 @@ static ssize_t store_mode(struct device *device, struct 
device_attribute *attr,
        struct fb_var_screeninfo var;
        struct fb_modelist *modelist;
        struct fb_videomode *mode;
-       struct list_head *pos;
        size_t i;
        int err;
 
        memset(&var, 0, sizeof(var));
 
-       list_for_each(pos, &fb_info->modelist) {
-               modelist = list_entry(pos, struct fb_modelist, list);
+       list_for_each_entry(modelist, &fb_info->modelist, list) {
                mode = &modelist->mode;
                i = mode_string(mstr, 0, mode);
                if (strncmp(mstr, buf, max(count, i)) == 0) {
@@ -198,13 +196,11 @@ static ssize_t show_modes(struct device *device, struct 
device_attribute *attr,
 {
        struct fb_info *fb_info = dev_get_drvdata(device);
        unsigned int i;
-       struct list_head *pos;
        struct fb_modelist *modelist;
        const struct fb_videomode *mode;
 
        i = 0;
-       list_for_each(pos, &fb_info->modelist) {
-               modelist = list_entry(pos, struct fb_modelist, list);
+       list_for_each_entry(modelist, &fb_info->modelist, list) {
                mode = &modelist->mode;
                i += mode_string(buf, i, mode);
        }
-- 
2.6.2

Reply via email to