Hi Rajeev
On Sat, Jun 19, 2021 at 04:10:30PM +0530, Rajeev Nandan wrote:
> Add Samsung 13.3" FHD eDP AMOLED panel.
>
> Signed-off-by: Rajeev Nandan <rajee...@codeaurora.org>
> Reviewed-by: Douglas Anderson <diand...@chromium.org>
> ---
>
> Changes in v4:
> - New
>
> Changes in v5:
> - Remove "uses_dpcd_backlight" property, not required now. (Douglas)
>
> Changes in v7:
> - Update disable_to_power_off and power_to_enable delays. (Douglas)
>
> drivers/gpu/drm/panel/panel-simple.c | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c
> index 86e5a45..4adc44a 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3562,6 +3562,36 @@ static const struct panel_desc rocktech_rk101ii01d_ct
> = {
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> };
>
> +static const struct drm_display_mode samsung_atna33xc20_mode = {
> + .clock = 138770,
> + .hdisplay = 1920,
> + .hsync_start = 1920 + 48,
> + .hsync_end = 1920 + 48 + 32,
> + .htotal = 1920 + 48 + 32 + 80,
> + .vdisplay = 1080,
> + .vsync_start = 1080 + 8,
> + .vsync_end = 1080 + 8 + 8,
> + .vtotal = 1080 + 8 + 8 + 16,
> + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc samsung_atna33xc20 = {
> + .modes = &samsung_atna33xc20_mode,
> + .num_modes = 1,
> + .bpc = 10,
> + .size = {
> + .width = 294,
> + .height = 165,
> + },
> + .delay = {
> + .disable_to_power_off = 200,
> + .power_to_enable = 400,
> + .hpd_absent_delay = 200,
> + .unprepare = 500,
> + },
> + .connector_type = DRM_MODE_CONNECTOR_eDP,
> +};
bus_format is missing. There should be a warning about this when you
probe the display.
The bpc of 10 in unusual, the current code warns if bpc is neither 6 nor
8. If 10 is correct then update the code to accept bpc=10.
Sam
> +
> static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
> .clock = 271560,
> .hdisplay = 2560,
> @@ -4563,6 +4593,9 @@ static const struct of_device_id platform_of_match[] = {
> .compatible = "rocktech,rk101ii01d-ct",
> .data = &rocktech_rk101ii01d_ct,
> }, {
> + .compatible = "samsung,atna33xc20",
> + .data = &samsung_atna33xc20,
> + }, {
> .compatible = "samsung,lsn122dl01-c01",
> .data = &samsung_lsn122dl01_c01,
> }, {
> --
> 2.7.4
