Hi Thomas, On Wed, Aug 04, 2021 at 08:30:41PM +0200, Thomas Zimmermann wrote: > Hi > > Am 03.08.21 um 17:00 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Tue, Aug 03, 2021 at 11:07:01AM +0200, Thomas Zimmermann wrote: > > > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > > > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > > > don't benefit from using it. > > > > > > DRM IRQ callbacks are now being called directly or inlined. > > > > > > Calls to platform_get_irq() can fail with a negative errno code. > > > Abort initialization in this case. The DRM IRQ midlayer does not > > > handle this case correctly. > > > > I cannot see why the irq_enabled flag is needed here, and the changelog > > do not help me. > > What do I miss? > > That's a good point. Usually, only the DRM IRQ helpers use irq_enabled in > struct drm_device. It'll become legacy and we can ignore it for the driver > conversion. > > The exception is tilcdc, which also uses irq_enabled to make its error > rollback work correctly. So I duplicated the state in the local private > structure. > > I'll add this explanation to the commit message. With this added: Acked-by: Sam Ravnborg <s...@ravnborg.org>
- [PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfa... Thomas Zimmermann
- Re: [PATCH v2 07/14] drm/msm: Convert to Linux IR... Dmitry Baryshkov
- Re: [Freedreno] [PATCH v2 07/14] drm/msm: Convert... abhinavk
- [PATCH v2 08/14] drm/mxsfb: Convert to Linux IRQ inter... Thomas Zimmermann
- [PATCH v2 05/14] drm/gma500: Convert to Linux IRQ inte... Thomas Zimmermann
- [PATCH v2 09/14] drm/radeon: Convert to Linux IRQ inte... Thomas Zimmermann
- [PATCH v2 11/14] drm/tilcdc: Convert to Linux IRQ inte... Thomas Zimmermann
- Re: [PATCH v2 11/14] drm/tilcdc: Convert to Linux... Sam Ravnborg
- Re: [PATCH v2 11/14] drm/tilcdc: Convert to L... Thomas Zimmermann
- Re: [PATCH v2 11/14] drm/tilcdc: Convert ... Sam Ravnborg
- [PATCH v2 13/14] drm: Remove unused devm_drm_irq_insta... Thomas Zimmermann
- [PATCH v2 10/14] drm/tidss: Convert to Linux IRQ inter... Thomas Zimmermann
- [PATCH v2 12/14] drm/vc4: Convert to Linux IRQ interfa... Thomas Zimmermann
- [PATCH v2 14/14] drm: IRQ midlayer is now legacy Thomas Zimmermann
- Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legac... Sam Ravnborg
- RE: [PATCH v2 00/14] drm: Make DRM's IRQ helpers ... Chrisanthus, Anitha
- Re: [PATCH v2 00/14] drm: Make DRM's IRQ help... Thomas Zimmermann
- RE: [PATCH v2 00/14] drm: Make DRM's IRQ ... Chrisanthus, Anitha
- Re: [PATCH v2 00/14] drm: Make DRM's ... Thomas Zimmermann