This was found by coccicheck:
./drivers/gpu/drm/kmb/kmb_drv.c:503:2-8:
ERROR  missing put_device; call of_find_device_by_node on line 490,
but without a corresponding object release within this function.

Reported-by: Zeal Robot <zea...@zte.com.cn>
Signed-off-by: jing yangyang <jing.yangy...@zte.com.cn>
---
 drivers/gpu/drm/kmb/kmb_drv.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c
index f54392e..58495a9 100644
--- a/drivers/gpu/drm/kmb/kmb_drv.c
+++ b/drivers/gpu/drm/kmb/kmb_drv.c
@@ -500,8 +500,10 @@ static int kmb_probe(struct platform_device *pdev)
        ret = kmb_dsi_host_bridge_init(get_device(&dsi_pdev->dev));
 
        if (ret == -EPROBE_DEFER) {
+               put_device(&dsi_pdev->dev);
                return -EPROBE_DEFER;
        } else if (ret) {
+               put_device(&dsi_pdev->dev);
                DRM_ERROR("probe failed to initialize DSI host bridge\n");
                return ret;
        }
@@ -509,9 +511,10 @@ static int kmb_probe(struct platform_device *pdev)
        /* Create DRM device */
        kmb = devm_drm_dev_alloc(dev, &kmb_driver,
                                 struct kmb_drm_private, drm);
-       if (IS_ERR(kmb))
+       if (IS_ERR(kmb)) {
+               put_device(&dsi_pdev->dev);
                return PTR_ERR(kmb);
-
+       }
        dev_set_drvdata(dev, &kmb->drm);
 
        /* Initialize MIPI DSI */
-- 
1.8.3.1


Reply via email to