From: Maarten Lankhorst <maarten.lankho...@linux.intel.com>

Resetting will clear the CONTEXT_VALID_BIT, so wait until after that to
test.

Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathap...@intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_engine_pm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pm.c 
b/drivers/gpu/drm/i915/gt/intel_engine_pm.c
index a1334b48dde7..849fbb229bd3 100644
--- a/drivers/gpu/drm/i915/gt/intel_engine_pm.c
+++ b/drivers/gpu/drm/i915/gt/intel_engine_pm.c
@@ -52,8 +52,6 @@ static int __engine_unpark(struct intel_wakeref *wf)
        /* Discard stale context state from across idling */
        ce = engine->kernel_context;
        if (ce) {
-               GEM_BUG_ON(test_bit(CONTEXT_VALID_BIT, &ce->flags));
-
                /* Flush all pending HW writes before we touch the context */
                while (unlikely(intel_context_inflight(ce)))
                        intel_engine_flush_submission(engine);
@@ -68,6 +66,9 @@ static int __engine_unpark(struct intel_wakeref *wf)
                         ce->timeline->seqno,
                         READ_ONCE(*ce->timeline->hwsp_seqno),
                         ce->ring->emit);
+
+               GEM_BUG_ON(test_bit(CONTEXT_VALID_BIT, &ce->flags));
+
                GEM_BUG_ON(ce->timeline->seqno !=
                           READ_ONCE(*ce->timeline->hwsp_seqno));
        }
-- 
2.26.3

Reply via email to