Trivial fix since we now need to grab a reference to the fence we have
added. Previously the dma_resv function where doing that for us.

Signed-off-by: Christian König <christian.koe...@amd.com>
Fixes: 9c2ba265352a ("drm/scheduler: use new iterator in 
drm_sched_job_add_implicit_dependencies v2")
Link: 
https://patchwork.freedesktop.org/patch/msgid/20211019112706.27769-1-christian.koe...@amd.com
Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch>
Reported-by: Nicolas Frattaroli <frattaroli.nico...@gmail.com>
References: https://lore.kernel.org/dri-devel/2023306.UmlnhvANQh@archbook/
Tested-by: Nicolas Frattaroli <frattaroli.nico...@gmail.com>
Tested-by: Yassine Oudjana <y.oudj...@protonmail.com>
---
 drivers/gpu/drm/scheduler/sched_main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/scheduler/sched_main.c 
b/drivers/gpu/drm/scheduler/sched_main.c
index 5bc5f775abe1..94fe51b3caa2 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -707,6 +707,9 @@ int drm_sched_job_add_implicit_dependencies(struct 
drm_sched_job *job,
                ret = drm_sched_job_add_dependency(job, fence);
                if (ret)
                        return ret;
+
+               /* Make sure to grab an additional ref on the added fence */
+               dma_fence_get(fence);
        }
        return 0;
 }
-- 
2.25.1

Reply via email to