Re: [PATCH 2/7] drm/i915/guc: Only assign guc_id.id when stealing guc_id

[John Harrison]

On 12/10/2021 16:56, Matthew Brost wrote:

Previously assigned whole guc_id structure (list, spin lock) which is
incorrect, only assign the guc_id.id.

Fixes: 0f7976506de61 ("drm/i915/guc: Rework and simplify locking")
Signed-off-by: Matthew Brost <matthew.br...@intel.com>

Reviewed-by: John Harrison <john.c.harri...@intel.com>

---
  drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c 
b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 9b7b4f4e0d91..0fb2eeff0262 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -1935,7 +1935,7 @@ static int steal_guc_id(struct intel_guc *guc, struct 
intel_context *ce)
                GEM_BUG_ON(intel_context_is_parent(cn));

list_del_init(&cn->guc_id.link);

-               ce->guc_id = cn->guc_id;
+               ce->guc_id.id = cn->guc_id.id;

spin_lock(&cn->guc_state.lock);

                clr_context_registered(cn);