On 08/12/2021 10:40, Biju Das wrote: > The Renesas RZ/G2{L, LC} SoC (a.k.a R9A07G044) has a Bifrost Mali-G31 GPU, > add a compatible string for it. > > Signed-off-by: Biju Das <biju.das...@bp.renesas.com> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad...@bp.renesas.com> > --- > v2->v3: > * Moved optional clock-names and reset-names to SoC-specific conditional > schemas. > * minimum number of reset for the generic GPU is set to 1. > * Documented number of clocks, resets, interrupts and interrupt-names in > RZ/G2L > SoC-specific conditional schemas. > v1->v2: > * Updated minItems for resets as 2 > * Documented optional property reset-names > * Documented reset-names as required property for RZ/G2L SoC. > --- > .../bindings/gpu/arm,mali-bifrost.yaml | 45 ++++++++++++++++++- > 1 file changed, 43 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > index 6f98dd55fb4c..63a08f3f321d 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > @@ -19,6 +19,7 @@ properties: > - amlogic,meson-g12a-mali > - mediatek,mt8183-mali > - realtek,rtd1619-mali > + - renesas,r9a07g044-mali > - rockchip,px30-mali > - rockchip,rk3568-mali > - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully > discoverable > @@ -27,19 +28,26 @@ properties: > maxItems: 1 > > interrupts: > + minItems: 3 > items: > - description: Job interrupt > - description: MMU interrupt > - description: GPU interrupt > + - description: Event interrupt > > interrupt-names: > + minItems: 3 > items: > - const: job > - const: mmu > - const: gpu > + - const: event
FWIW: I think it's fair to add the "event" interrupt even if it isn't included in the bindings for kbase. While pretty much useless on Bifrost it is a hardware feature and in theory it could be used. Reviewed-by: Steven Price <steven.pr...@arm.com> Steve > > clocks: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 > + > + clock-names: true > > mali-supply: true > > @@ -52,7 +60,10 @@ properties: > maxItems: 3 > > resets: > - maxItems: 2 > + minItems: 1 > + maxItems: 3 > + > + reset-names: true > > "#cooling-cells": > const: 2 > @@ -94,6 +105,36 @@ allOf: > then: > required: > - resets > + - if: > + properties: > + compatible: > + contains: > + const: renesas,r9a07g044-mali > + then: > + properties: > + interrupts: > + minItems: 4 > + interrupt-names: > + minItems: 4 > + clocks: > + minItems: 3 > + clock-names: > + items: > + - const: gpu > + - const: bus > + - const: bus_ace > + resets: > + minItems: 3 > + reset-names: > + items: > + - const: rst > + - const: axi_rst > + - const: ace_rst > + required: > + - clock-names > + - power-domains > + - resets > + - reset-names > - if: > properties: > compatible: >