From: Thierry Reding <tred...@nvidia.com>

This function can return one of several errors in an ERR_PTR()-encoded
pointer, so make sure to propogate those on failure.

Suggested-by: Robin Murphy <robin.mur...@arm.com>
Signed-off-by: Thierry Reding <tred...@nvidia.com>
---
 drivers/gpu/drm/tegra/vic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
index c5f4d2b13c43..7d2b719ed8d1 100644
--- a/drivers/gpu/drm/tegra/vic.c
+++ b/drivers/gpu/drm/tegra/vic.c
@@ -237,6 +237,8 @@ static int vic_load_firmware(struct vic *vic)
                        return -ENOMEM;
        } else {
                virt = tegra_drm_alloc(tegra, size, &iova);
+               if (IS_ERR(virt))
+                       return PTR_ERR(virt);
        }
 
        vic->falcon.firmware.virt = virt;
-- 
2.34.1

Reply via email to