Hello Kevin, On 12/24/21 15:12, Kevin Tang wrote: > On linux-next, commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master") > adds the config DRM_SPRD, > which selects DRM_KMS_CMA_HELPER. >
According to "The canonical patch format" section in [0], the body of the explanation has to be line wrapped at 75 columns. But your sentences are much longer than that. [0]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format > However, commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") > just removed the > DRM_KMS_CMA_HELPER. So, the select DRM_KMS_CMA_HELPER refers to a > non-existing kconfig symbol. > > Cc: Orson Zhai <orsonz...@gmail.com> > Cc: Chunyan Zhang <zhang.l...@gmail.com> > Signed-off-by: Kevin Tang <kevin.t...@unisoc.com> > --- Other than that, the patch looks good to me. Reviewed-by: Javier Martinez Canillas <javi...@redhat.com> Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat