Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

[Thomas Zimmermann]

Hi

Am 01.02.22 um 09:36 schrieb Geert Uytterhoeven:

Hi Simon,

On Tue, Feb 1, 2022 at 9:34 AM Simon Ser <cont...@emersion.fr> wrote:

On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven 
<ge...@linux-m68k.org> wrote:

What's the story with the Rn formats?

The comments say "n bpp Red", while this is a monochrome (even
inverted) display?

I don't think the color matters that much. "Red" was picked just because it was
an arbitrary color, to make the difference with e.g. C8. Or am I mistaken?

I'd expect 8-bit grayscale to be Y8 instead.

Best regards
Thomas

I like this naming, but DRM_FORMAT_R8 is uapi already. :/ If anything, we could add Yn formats in addition to existing Rn formats.

Gr{oetje,eeting}s,

                         Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                 -- Linus Torvalds

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

OpenPGP_signature
Description: OpenPGP digital signature