Hi Dmitry,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm/drm-next]
[also build test ERROR on v5.17-rc2 next-20220201]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Dmitry-Baryshkov/drm-msm-dpu-simplify-IRQ-helpers/20220201-231430
base:   git://anongit.freedesktop.org/drm/drm drm-next
config: arc-randconfig-r043-20220130 
(https://download.01.org/0day-ci/archive/20220202/202202020658.fjtv4cap-...@intel.com/config)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/0day-ci/linux/commit/c3da64f5022acf9d942f497a3e3cff092648d6c3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Dmitry-Baryshkov/drm-msm-dpu-simplify-IRQ-helpers/20220201-231430
        git checkout c3da64f5022acf9d942f497a3e3cff092648d6c3
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross 
O=build_dir ARCH=arc SHELL=/bin/bash drivers/gpu/drm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/trace/define_trace.h:102,
                    from drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h:973,
                    from drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:34:
   drivers/gpu/drm/msm/disp/dpu1/./dpu_trace.h: In function 
'ftrace_test_probe_dpu_core_irq_unregister_callback':
>> include/trace/trace_events.h:870:42: error: passing argument 1 of 
>> 'check_trace_callback_type_dpu_core_irq_unregister_callback' from 
>> incompatible pointer type [-Werror=incompatible-pointer-types]
     870 |         
check_trace_callback_type_##call(trace_event_raw_event_##template); \
         |                                          ^~~~~~~~~~~~~~~~~~~~~~
         |                                          |
         |                                          void (*)(void *, int,  void 
*)
   drivers/gpu/drm/msm/disp/dpu1/./dpu_trace.h:892:1: note: in expansion of 
macro 'DEFINE_EVENT'
     892 | DEFINE_EVENT(dpu_core_irq_callback_template, 
dpu_core_irq_unregister_callback,
         | ^~~~~~~~~~~~
   In file included from drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h:10,
                    from drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:34:
   include/linux/tracepoint.h:279:49: note: expected 'void (*)(void *, int)' 
but argument is of type 'void (*)(void *, int,  void *)'
     279 |         check_trace_callback_type_##name(void (*cb)(data_proto))     
   \
         |                                          ~~~~~~~^~~~~~~~~~~~~~~
   include/linux/tracepoint.h:419:9: note: in expansion of macro 
'__DECLARE_TRACE'
     419 |         __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),           
   \
         |         ^~~~~~~~~~~~~~~
   include/linux/tracepoint.h:542:9: note: in expansion of macro 'DECLARE_TRACE'
     542 |         DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
         |         ^~~~~~~~~~~~~
   drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h:892:1: note: in expansion of macro 
'DEFINE_EVENT'
     892 | DEFINE_EVENT(dpu_core_irq_callback_template, 
dpu_core_irq_unregister_callback,
         | ^~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/check_trace_callback_type_dpu_core_irq_unregister_callback +870 
include/trace/trace_events.h

46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  830) 
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  831) #undef 
DECLARE_EVENT_CLASS
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  832) #define 
DECLARE_EVENT_CLASS(call, proto, args, tstruct, assign, print)        \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  833)                       
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  834) static notrace void   
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  835) 
trace_event_raw_event_##call(void *__data, proto)                     \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  836) {                     
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  837)       struct 
trace_event_file *trace_file = __data;                   \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  838)       struct 
trace_event_data_offsets_##call __maybe_unused __data_offsets;\
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  839)       struct 
trace_event_buffer fbuffer;                              \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  840)       struct 
trace_event_raw_##call *entry;                           \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  841)       int 
__data_size;                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  842)                       
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  843)       if 
(trace_trigger_soft_disabled(trace_file))                    \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  844)               return; 
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  845)                       
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  846)       __data_size = 
trace_event_get_offsets_##call(&__data_offsets, args); \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  847)                       
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  848)       entry = 
trace_event_buffer_reserve(&fbuffer, trace_file,        \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  849)                       
         sizeof(*entry) + __data_size);         \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  850)                       
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  851)       if (!entry)     
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  852)               return; 
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  853)                       
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  854)       tstruct         
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  855)                       
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  856)       { assign; }     
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  857)                       
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  858)       
trace_event_buffer_commit(&fbuffer);                            \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  859) }
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  860) /*
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  861)  * The 
ftrace_test_probe is compiled out, it is only here as a build time check
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  862)  * to make sure that 
if the tracepoint handling changes, the ftrace probe will
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  863)  * fail to compile 
unless it too is updated.
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  864)  */
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  865) 
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  866) #undef DEFINE_EVENT
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  867) #define 
DEFINE_EVENT(template, call, proto, args)                     \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  868) static inline void 
ftrace_test_probe_##call(void)                     \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  869) {                     
                                                \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23 @870)       
check_trace_callback_type_##call(trace_event_raw_event_##template); \
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  871) }
46ac51822a6a0b8 Steven Rostedt (Red Hat  2015-09-23  872) 

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Reply via email to