On Wed, Feb 09, 2022 at 10:03:10AM +0100, Javier Martinez Canillas wrote:
> + if (ssd130x->vbat_reg) {
> + ret = regulator_enable(ssd130x->vbat_reg);
> + if (ret) {
> + dev_err(dev, "Failed to enable VBAT: %d\n", ret);
> + return ret;
> + }
> + }Unless the device supports power being physically omitted regulator usage should not be optional, it's just more code and a recipie for poor error handling.
signature.asc
Description: PGP signature
