This bit of code is (e)DP and aux I2C link specific, move it into
tc_aux_link_setup() to permit cleaner addition of DSI-to-DPI mode.
No functional change.

Reviewed-by: Lucas Stach <[email protected]>
Tested-by: Lucas Stach <[email protected]> # In both DPI to eDP and DSI to 
DPI mode.
Signed-off-by: Marek Vasut <[email protected]>
Cc: Jonas Karlman <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Sam Ravnborg <[email protected]>
---
V2: - New patch
V3: - Add RB from Lucas
V4: - Add TB from Lucas
---
 drivers/gpu/drm/bridge/tc358767.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/tc358767.c 
b/drivers/gpu/drm/bridge/tc358767.c
index 0f24156543bae..8a8b495aa0ad1 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -656,6 +656,12 @@ static int tc_aux_link_setup(struct tc_data *tc)
        if (ret)
                goto err;
 
+       /* Register DP AUX channel */
+       tc->aux.name = "TC358767 AUX i2c adapter";
+       tc->aux.dev = tc->dev;
+       tc->aux.transfer = tc_aux_transfer;
+       drm_dp_aux_init(&tc->aux);
+
        return 0;
 err:
        dev_err(tc->dev, "tc_aux_link_setup failed: %d\n", ret);
@@ -1736,12 +1742,6 @@ static int tc_probe(struct i2c_client *client, const 
struct i2c_device_id *id)
        if (ret)
                return ret;
 
-       /* Register DP AUX channel */
-       tc->aux.name = "TC358767 AUX i2c adapter";
-       tc->aux.dev = tc->dev;
-       tc->aux.transfer = tc_aux_transfer;
-       drm_dp_aux_init(&tc->aux);
-
        tc->bridge.funcs = &tc_edp_bridge_funcs;
        if (tc->hpd_pin >= 0)
                tc->bridge.ops |= DRM_BRIDGE_OP_DETECT;
-- 
2.35.1

Reply via email to