> Subject: [PATCH v3] drm/hyperv: Added error message for fb size greater than > allocated > > Added error message when the size of requested framebuffer is more than > the allocated size by vmbus mmio region for framebuffer
"Added" --> "Add"? My impression is that we don't use past tense in the Subject and the commit message. See "git log drivers/gpu/drm/hyperv/hyperv_drm_modeset.c". > --- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c > +++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c > @@ -123,8 +123,11 @@ static int hyperv_pipe_check(struct > drm_simple_display_pipe *pipe, > if (fb->format->format != DRM_FORMAT_XRGB8888) > return -EINVAL; > > - if (fb->pitches[0] * fb->height > hv->fb_size) > + if (fb->pitches[0] * fb->height > hv->fb_size) { > + drm_err(&hv->dev, "hv->hdev, fb size requested by process %s > for %d X %d (pitch %d) is greater than allocated size %ld\n", Should we use drm_err_ratelimited() instead of drm_err()? The line exceeds 80 chars. > + current->comm, fb->width, fb->height, fb->pitches[0], > hv->fb_size); > return -EINVAL; > + } Maybe we can use the below: drm_err_ratelimited(&hv->dev, "%s: requested %dX%d (pitch %d) " "exceeds fb_size %ld\n", current->comm, fb->width, fb->height, fb->pitches[0], hv->fb_size); Note: the first chars of last 3 lines should align with the "&" in the same column. Please run "scripts/checkpatch.pl" against the patch.