Hello José, On 6/6/22 11:55, José Expósito wrote: > Test the conversion from XRGB8888 to RGB332. > > What is tested? > > - Different values for the X in XRGB8888 to make sure it is ignored > - Different clip values: Single pixel and full and partial buffer > - Well known colors: White, black, red, green, blue, magenta, yellow > and cyan > - Other colors: Randomly picked > - Destination pitch > > How to run the tests? > > $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm \ > --kconfig_add CONFIG_VIRTIO_UML=y \ > --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y > > Suggested-by: Javier Martinez Canillas <javi...@redhat.com> > Signed-off-by: José Expósito <jose.exposit...@gmail.com> > > ---
Thanks for addressing the issues pointed out. Patch looks good to me now. Reviewed-by: Javier Martinez Canillas <javi...@redhat.com> By the way, I think you should request an account [0], so that you can push patches to drm-misc directly. Specially since AFAIU the plan is to add more KUnit tests in future patch series. [0]: https://www.freedesktop.org/wiki/AccountRequests/ -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
