If we fail to enable the DPI clock, we just ignore the error and moves
forward. Let's return an error instead.

Signed-off-by: Maxime Ripard <max...@cerno.tech>
---
 drivers/gpu/drm/vc4/vc4_dpi.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c
index d1eaafb43bd1..658e0aa9e2e1 100644
--- a/drivers/gpu/drm/vc4/vc4_dpi.c
+++ b/drivers/gpu/drm/vc4/vc4_dpi.c
@@ -270,6 +270,7 @@ static int vc4_dpi_bind(struct device *dev, struct device 
*master, void *data)
                        DRM_ERROR("Failed to get core clock: %d\n", ret);
                return ret;
        }
+
        dpi->pixel_clock = devm_clk_get(dev, "pixel");
        if (IS_ERR(dpi->pixel_clock)) {
                ret = PTR_ERR(dpi->pixel_clock);
@@ -279,8 +280,10 @@ static int vc4_dpi_bind(struct device *dev, struct device 
*master, void *data)
        }
 
        ret = clk_prepare_enable(dpi->core_clock);
-       if (ret)
+       if (ret) {
                DRM_ERROR("Failed to turn on core clock: %d\n", ret);
+               return ret;
+       }
 
        drm_simple_encoder_init(drm, &dpi->encoder.base, DRM_MODE_ENCODER_DPI);
        drm_encoder_helper_add(&dpi->encoder.base, 
&vc4_dpi_encoder_helper_funcs);
-- 
2.36.1

Reply via email to