Joe Perches <j...@perches.com> writes:
> On Sat, 2022-06-25 at 19:00 -0700, David Reaver wrote: >> Fix alignment of this line of code with the previous parenthesis, as >> suggested by checkpatch.pl: > [] >> diff --git a/drivers/staging/fbtft/fb_tinylcd.c >> b/drivers/staging/fbtft/fb_tinylcd.c > [] >> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par) >> write_reg(par, 0xE5, 0x00); >> write_reg(par, 0xF0, 0x36, 0xA5, 0x53); >> write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00, >> - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); >> + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); > > It's probably better to ignore the message in this case as the first > argument means something and the second and subsequent are the data > being written via a specific macro using NUMARGS. Thanks for taking a look Joe! That makes sense. I'm new to the kernel and running checkpath.pl on staging drivers was suggested as a good place to start contributing, but I'll keep a more careful eye out next time and not follow checkpath blindly.
