On 2022-07-12 07:32, Melissa Wen wrote:
> Check the value of per_pixel_alpha to decide whether the Coverage pixel
> blend mode is applicable or not.
>
> Fixes: 76818cdd11a2 ("drm/amd/display: add Coverage blend mode for overlay
> plane")
> Reported-by: kernel test robot <l...@intel.com>
> Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
> Signed-off-by: Melissa Wen <m...@igalia.com>
Reviewed-by: Harry Wentland <harry.wentl...@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index de1c139ae279..25cb833b267c 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -5486,7 +5486,7 @@ fill_blending_from_plane_state(const struct
> drm_plane_state *plane_state,
> }
> }
>
> - if (per_pixel_alpha && plane_state->pixel_blend_mode ==
> DRM_MODE_BLEND_COVERAGE)
> + if (*per_pixel_alpha && plane_state->pixel_blend_mode ==
> DRM_MODE_BLEND_COVERAGE)
> *pre_multiplied_alpha = false;
> }
>
