Hi Maxime, I love your patch! Yet something to improve:
[auto build test ERROR on 37b355fdaf31ee18bda9a93c2a438dc1cbf57ec9] url: https://github.com/intel-lab-lkp/linux/commits/Maxime-Ripard/drm-Analog-TV-Improvements/20220730-004859 base: 37b355fdaf31ee18bda9a93c2a438dc1cbf57ec9 config: hexagon-randconfig-r041-20220729 (https://download.01.org/0day-ci/archive/20220730/202207300305.egsdojh4-...@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 8dfaecc4c24494337933aff9d9166486ca0949f1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/83327cd72054a9c8d02b6f632453a8bdc90d3797 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Maxime-Ripard/drm-Analog-TV-Improvements/20220730-004859 git checkout 83327cd72054a9c8d02b6f632453a8bdc90d3797 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/gpu/drm/i2c/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): >> drivers/gpu/drm/i2c/ch7006_drv.c:253:51: error: too many arguments to >> function call, expected 2, have 3 drm_mode_create_tv_properties(dev, NUM_TV_NORMS, ch7006_tv_norm_names); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~ include/drm/drm_connector.h:1807:5: note: 'drm_mode_create_tv_properties' declared here int drm_mode_create_tv_properties(struct drm_device *dev, ^ 1 error generated. vim +253 drivers/gpu/drm/i2c/ch7006_drv.c 6ee738610f41b5 Ben Skeggs 2009-12-11 245 6ee738610f41b5 Ben Skeggs 2009-12-11 246 static int ch7006_encoder_create_resources(struct drm_encoder *encoder, 6ee738610f41b5 Ben Skeggs 2009-12-11 247 struct drm_connector *connector) 6ee738610f41b5 Ben Skeggs 2009-12-11 248 { 6ee738610f41b5 Ben Skeggs 2009-12-11 249 struct ch7006_priv *priv = to_ch7006_priv(encoder); 6ee738610f41b5 Ben Skeggs 2009-12-11 250 struct drm_device *dev = encoder->dev; 6ee738610f41b5 Ben Skeggs 2009-12-11 251 struct drm_mode_config *conf = &dev->mode_config; 6ee738610f41b5 Ben Skeggs 2009-12-11 252 6ee738610f41b5 Ben Skeggs 2009-12-11 @253 drm_mode_create_tv_properties(dev, NUM_TV_NORMS, ch7006_tv_norm_names); 6ee738610f41b5 Ben Skeggs 2009-12-11 254 d9bc3c02e36d84 Sascha Hauer 2012-02-06 255 priv->scale_property = drm_property_create_range(dev, 0, "scale", 0, 2); 44084efc2fd804 Insu Yun 2016-01-28 256 if (!priv->scale_property) 44084efc2fd804 Insu Yun 2016-01-28 257 return -ENOMEM; 6ee738610f41b5 Ben Skeggs 2009-12-11 258 ec61c71d0dba24 Rob Clark 2012-10-11 259 drm_object_attach_property(&connector->base, conf->tv_select_subconnector_property, 6ee738610f41b5 Ben Skeggs 2009-12-11 260 priv->select_subconnector); ec61c71d0dba24 Rob Clark 2012-10-11 261 drm_object_attach_property(&connector->base, conf->tv_subconnector_property, 6ee738610f41b5 Ben Skeggs 2009-12-11 262 priv->subconnector); ec61c71d0dba24 Rob Clark 2012-10-11 263 drm_object_attach_property(&connector->base, conf->tv_left_margin_property, 6ee738610f41b5 Ben Skeggs 2009-12-11 264 priv->hmargin); ec61c71d0dba24 Rob Clark 2012-10-11 265 drm_object_attach_property(&connector->base, conf->tv_bottom_margin_property, 6ee738610f41b5 Ben Skeggs 2009-12-11 266 priv->vmargin); ec61c71d0dba24 Rob Clark 2012-10-11 267 drm_object_attach_property(&connector->base, conf->tv_mode_property, 6ee738610f41b5 Ben Skeggs 2009-12-11 268 priv->norm); ec61c71d0dba24 Rob Clark 2012-10-11 269 drm_object_attach_property(&connector->base, conf->tv_brightness_property, 6ee738610f41b5 Ben Skeggs 2009-12-11 270 priv->brightness); ec61c71d0dba24 Rob Clark 2012-10-11 271 drm_object_attach_property(&connector->base, conf->tv_contrast_property, 6ee738610f41b5 Ben Skeggs 2009-12-11 272 priv->contrast); ec61c71d0dba24 Rob Clark 2012-10-11 273 drm_object_attach_property(&connector->base, conf->tv_flicker_reduction_property, 6ee738610f41b5 Ben Skeggs 2009-12-11 274 priv->flicker); ec61c71d0dba24 Rob Clark 2012-10-11 275 drm_object_attach_property(&connector->base, priv->scale_property, 6ee738610f41b5 Ben Skeggs 2009-12-11 276 priv->scale); 6ee738610f41b5 Ben Skeggs 2009-12-11 277 6ee738610f41b5 Ben Skeggs 2009-12-11 278 return 0; 6ee738610f41b5 Ben Skeggs 2009-12-11 279 } 6ee738610f41b5 Ben Skeggs 2009-12-11 280 -- 0-DAY CI Kernel Test Service https://01.org/lkp
